Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image saving in HelloDrone #4658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix image saving in HelloDrone #4658

wants to merge 1 commit into from

Conversation

webshared
Copy link

Fixes: #HelloDrone never asked to save image.

About

Fixed HelloDrone/main.cpp code to ask for path and save images. There was a simple bug.

How Has This Been Tested?

Run locally with AirSim, images saved as expected.

Screenshots (if appropriate):

After the fix applied:

 % ./main 
Waiting for connection - X

Connected!

Client Ver:1 (Min Req:1), Server Ver:1 (Min Req:1)
Press Enter to get FPV image
# of images received: 2
Enter path with ending separator to save images (leave empty for no save)
./img/
Image uint8 size: 62355
Image float size: 0
Image uint8 size: 0
Image float size: 36864
Press Enter to arm the drone

@xxEoD2242
Copy link

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

@webshared
Copy link
Author

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

Hey @xxEoD2242, sure pls merge into Colosseum, it has the same issue as I see.

@xxEoD2242
Copy link

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

Hey @xxEoD2242, sure pls merge into Colosseum, it has the same issue as I see.

Done -> Colosseum PR #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webshared @xxEoD2242